[Bug Fix] Wrapper will not print false attributes #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a major BC 😢 // ...
'wrapper' = > [
'customAttr' => false,
]I will be merging the fix for 🙏 |
|
@pxpm as we discussed, this is now validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for both;
linkTargetcolumn helper #5391 (comment)WHY
BEFORE - What was wrong? What was happening before this PR?
Some links where empty:
AFTER - What is happening after this PR?
No more empty links.
HOW
How did you achieve that, in technical terms?
All
wrapper_startfiles (for columns, fields and widgets) will check if the value of attribute is NOTfalse.Basically if someone has a closure for an HREF, or any other attribute, that attribute will be always printed in the HTML Dom element, even if the value is
false, ornull.With this PR, developers can control that by returning
falseon the closure, it's a strict validation so any falsy value will be printed anyway,0,null(even though null is not really printed on the html).href=""href="0"href=""Is it a breaking change?
I don't believe so.
This is only a breaking change for users who were returning false on some closure, and were expecting the attribute to be rendered empty.
How can we test the before & after?
By following @karandatwani92 suggestion here #5391 (comment)